Skip to content

feat: 푸터 컴포넌트 추가 #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dkkim0122 merged 2 commits into from
Dec 18, 2024
Merged

feat: 푸터 컴포넌트 추가 #28

dkkim0122 merged 2 commits into from
Dec 18, 2024

Conversation

@dkkim0122
Copy link
Collaborator

@dkkim0122 dkkim0122 commented Dec 17, 2024

작업 내용

  • 푸터 컴포넌트를 추가합니다.

참고사항

  • tailwind screen의 커스텀 theme이 모두 min-width 기준이라, 모바일 화면을 나타내는 데 어려움이 있어 모바일 theme을 새로 추가하였습니다.

이미지 혹은 동영상

image

해야 할 것

  • 새로고침 시 푸터만 남고 나머지가 사라졌다 나타나는 현상 해결
  • sns 목록 fixture나 constant로 옮겨 사이드바 메뉴와 함께 사용하도록 개선

@dkkim0122 dkkim0122 added the enhancement New feature or request label Dec 17, 2024
@dkkim0122 dkkim0122 requested a review from Gn0lee December 17, 2024 15:04
@dkkim0122 dkkim0122 self-assigned this Dec 17, 2024
Gn0lee
Gn0lee approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@Gn0lee Gn0lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dkkim0122 dkkim0122 merged commit 1570792 into develop Dec 18, 2024
2 checks passed
@dkkim0122 dkkim0122 deleted the feature/set-page-footer branch December 18, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gn0lee Gn0lee Gn0lee approved these changes

Assignees

@dkkim0122 dkkim0122

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dkkim0122 @Gn0lee